luke-else/subnet_calculator
1
0
Fork 0
Code Issues 3 Pull Requests Projects Releases Wiki Activity

Update from_arr and to_arr #3

New Issue
Open
opened 2023-05-15 18:45:48 +00:00 by luke-else · 2 comments
luke-else commented 2023-05-15 18:45:48 +00:00
Owner
Copy Link

Make these functions use traits as opposed to solo implementations, no need to rebuild a wheel.

Will also need to look at all of the references to where it is used already.

Make these functions use traits as opposed to solo implementations, no need to rebuild a wheel. Will also need to look at all of the references to where it is used already.
luke-else commented 2023-05-15 19:46:55 +00:00
Author
Owner
Copy Link

Doing so would currently create a stack overflow because of a cross dependency between u32::from(IpAddr) and the IpAddr::to_arr() function

Doing so would currently create a stack overflow because of a cross dependency between u32::from(IpAddr) and the IpAddr::to_arr() function
luke-else commented 2023-05-15 19:48:53 +00:00
Author
Owner
Copy Link

And because of our current implementation and reliance of us being able to refuse IPv6 Addresses, it would be quite a large and complex change to get this to work.

And because of our current implementation and reliance of us being able to refuse IPv6 Addresses, it would be quite a large and complex change to get this to work.
luke-else added reference master 2023-05-15 19:48:57 +00:00
luke-else added the
enhancement
 label 2023-05-15 19:49:01 +00:00
luke-else self-assigned this 2023-05-15 19:49:09 +00:00
Sign in to join this conversation.
master
Branches Tags
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
luke-else
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: luke-else/subnet_calculator#3
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?