Update from_arr and to_arr #3

New Issue

2023-05-15T18:45:48Z

luke-else commented

2023-05-15 18:45:48 +00:00

Make these functions use traits as opposed to solo implementations, no need to rebuild a wheel.

Will also need to look at all of the references to where it is used already.

Make these functions use traits as opposed to solo implementations, no need to rebuild a wheel. Will also need to look at all of the references to where it is used already.

luke-else commented

2023-05-15 19:46:55 +00:00

Doing so would currently create a stack overflow because of a cross dependency between u32::from(IpAddr) and the IpAddr::to_arr() function

luke-else commented

2023-05-15 19:48:53 +00:00

And because of our current implementation and reliance of us being able to refuse IPv6 Addresses, it would be quite a large and complex change to get this to work.

luke-else added reference master

2023-05-15 19:48:57 +00:00

luke-else added the enhancement label 2023-05-15 19:49:01 +00:00

luke-else self-assigned this 2023-05-15 19:49:09 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: luke-else/subnet_calculator#3