Applied auto pep 8 changes
This commit is contained in:
parent
f227727c74
commit
44c1ee03ba
3
app.py
3
app.py
@ -7,6 +7,8 @@ from controllers.web.endpoints import blueprint
|
||||
Initialises any components that are needed at runtime such as the
|
||||
Database manager...
|
||||
'''
|
||||
|
||||
|
||||
def main():
|
||||
app = Flask(__name__)
|
||||
|
||||
@ -23,5 +25,6 @@ def main():
|
||||
app.register_blueprint(blueprint)
|
||||
app.run(debug=True, host="0.0.0.0")
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
|
@ -1,6 +1,7 @@
|
||||
from .database import DatabaseController
|
||||
from models.category import Category
|
||||
|
||||
|
||||
class CategoryController(DatabaseController):
|
||||
FIELDS = ['id', 'name']
|
||||
|
||||
@ -18,7 +19,6 @@ class CategoryController(DatabaseController):
|
||||
)
|
||||
self._conn.commit()
|
||||
|
||||
|
||||
def read(self, id: int = 0) -> Category | None:
|
||||
params = [
|
||||
id
|
||||
@ -38,7 +38,6 @@ class CategoryController(DatabaseController):
|
||||
|
||||
return obj
|
||||
|
||||
|
||||
def read_all(self) -> list[Category] | None:
|
||||
cursor = self._conn.execute(
|
||||
"SELECT * FROM Categories",
|
||||
|
@ -3,6 +3,7 @@ from typing import Mapping, Any
|
||||
import sqlite3
|
||||
import os
|
||||
|
||||
|
||||
class DatabaseController(ABC):
|
||||
__data_dir = "./data/"
|
||||
__db_name = "wmgzon.db"
|
||||
@ -13,13 +14,13 @@ class DatabaseController(ABC):
|
||||
|
||||
__sqlitefile = __data_dir + __db_name
|
||||
|
||||
|
||||
def __init__(self):
|
||||
self._conn = None
|
||||
try:
|
||||
# Creates a connection and specifies a flag to parse all types back down into
|
||||
# Python declared types e.g. date & time
|
||||
self._conn = sqlite3.connect(self.__sqlitefile, detect_types=sqlite3.PARSE_DECLTYPES)
|
||||
self._conn = sqlite3.connect(
|
||||
self.__sqlitefile, detect_types=sqlite3.PARSE_DECLTYPES)
|
||||
except sqlite3.Error as e:
|
||||
# Close the connection if still open
|
||||
if self._conn:
|
||||
@ -32,6 +33,7 @@ class DatabaseController(ABC):
|
||||
|
||||
""" Takes a dictionary of fields and returns the object
|
||||
with those fields populated """
|
||||
|
||||
def new_instance(self, of: type, with_fields: Mapping[str, Any]):
|
||||
obj = of.__new__(of)
|
||||
for attr, value in with_fields.items():
|
||||
|
@ -1,8 +1,10 @@
|
||||
from .database import DatabaseController
|
||||
from models.products.product import Product
|
||||
|
||||
|
||||
class ProductController(DatabaseController):
|
||||
FIELDS = ['id', 'name', 'image', 'description', 'cost', 'category', 'sellerID', 'postedDate', 'quantityAvailable']
|
||||
FIELDS = ['id', 'name', 'image', 'description', 'cost',
|
||||
'category', 'sellerID', 'postedDate', 'quantityAvailable']
|
||||
|
||||
def __init__(self):
|
||||
super().__init__()
|
||||
@ -25,7 +27,6 @@ class ProductController(DatabaseController):
|
||||
)
|
||||
self._conn.commit()
|
||||
|
||||
|
||||
def read(self, name: str = "") -> list[Product] | None:
|
||||
params = [
|
||||
"%" + name + "%"
|
||||
@ -50,7 +51,6 @@ class ProductController(DatabaseController):
|
||||
|
||||
return products
|
||||
|
||||
|
||||
def read_all(self, category: str = "", search_term: str = "") -> list[Product] | None:
|
||||
params = [
|
||||
"%" + category + "%",
|
||||
|
@ -3,8 +3,10 @@ from models.users.user import User
|
||||
from models.users.customer import Customer
|
||||
from models.users.seller import Seller
|
||||
|
||||
|
||||
class UserController(DatabaseController):
|
||||
FIELDS = ['id', 'username', 'password', 'firstName', 'lastName', 'email', 'phone', 'role']
|
||||
FIELDS = ['id', 'username', 'password', 'firstName',
|
||||
'lastName', 'email', 'phone', 'role']
|
||||
|
||||
def __init__(self):
|
||||
super().__init__()
|
||||
@ -50,7 +52,6 @@ class UserController(DatabaseController):
|
||||
|
||||
return None
|
||||
|
||||
|
||||
def read_id(self, id: int) -> User | None:
|
||||
params = [
|
||||
id
|
||||
@ -74,6 +75,7 @@ class UserController(DatabaseController):
|
||||
return obj
|
||||
|
||||
return None
|
||||
|
||||
def update(self):
|
||||
print("Doing work")
|
||||
|
||||
|
@ -16,7 +16,7 @@ blueprint.register_blueprint(product.blueprint)
|
||||
|
||||
# Function that returns a given user class based on the ID in the session
|
||||
@blueprint.context_processor
|
||||
def get_user() -> dict[User|None]:
|
||||
def get_user() -> dict[User | None]:
|
||||
# Get the user based on the user ID
|
||||
user_id = session.get('user_id')
|
||||
user = None
|
||||
|
@ -15,14 +15,18 @@ import pathlib
|
||||
|
||||
ALLOWED_EXTENSIONS = {'png', 'jpg', 'jpeg', 'gif'}
|
||||
|
||||
|
||||
def allowed_file(filename):
|
||||
return '.' in filename and \
|
||||
filename.rsplit('.', 1)[1].lower() in ALLOWED_EXTENSIONS
|
||||
|
||||
|
||||
blueprint = Blueprint("products", __name__, url_prefix="/products")
|
||||
|
||||
# Global context to enable the categories to be accessed
|
||||
# from any view
|
||||
|
||||
|
||||
@blueprint.context_processor
|
||||
def category_list():
|
||||
database = CategoryController()
|
||||
@ -30,6 +34,8 @@ def category_list():
|
||||
return dict(categories=categories)
|
||||
|
||||
# Loads the front product page
|
||||
|
||||
|
||||
@blueprint.route('/')
|
||||
def index():
|
||||
database = ProductController()
|
||||
@ -39,9 +45,11 @@ def index():
|
||||
if products == None:
|
||||
flash("No Products available")
|
||||
|
||||
return render_template('index.html', content="content.html", products = products)
|
||||
return render_template('index.html', content="content.html", products=products)
|
||||
|
||||
# Loads a given product category page
|
||||
|
||||
|
||||
@blueprint.route('/<string:category>')
|
||||
def category(category: str):
|
||||
database = ProductController()
|
||||
@ -58,9 +66,11 @@ def category(category: str):
|
||||
if products == None:
|
||||
flash(f"No Products available in {category}")
|
||||
|
||||
return render_template('index.html', content="content.html", products = products, category = category)
|
||||
return render_template('index.html', content="content.html", products=products, category=category)
|
||||
|
||||
# Loads a given product based on ID
|
||||
|
||||
|
||||
@blueprint.route('/<int:id>')
|
||||
def id(id: int):
|
||||
return "ID: " + str(id)
|
||||
|
@ -10,13 +10,17 @@ from hashlib import sha512
|
||||
# Blueprint to append user endpoints to
|
||||
blueprint = Blueprint("users", __name__)
|
||||
|
||||
### LOGIN FUNCTIONALITY
|
||||
# LOGIN FUNCTIONALITY
|
||||
# Function responsible for delivering the Login page for the site
|
||||
|
||||
|
||||
@blueprint.route('/login')
|
||||
def display_login():
|
||||
return render_template('index.html', content="login.html")
|
||||
|
||||
# Function responsible for handling logins to the site
|
||||
|
||||
|
||||
@blueprint.post('/login')
|
||||
def login():
|
||||
database = UserController()
|
||||
@ -39,13 +43,15 @@ def login():
|
||||
return redirect("/")
|
||||
|
||||
|
||||
### SIGNUP FUNCTIONALITY
|
||||
# SIGNUP FUNCTIONALITY
|
||||
# Function responsible for delivering the Signup page for the site
|
||||
@blueprint.route('/signup')
|
||||
def display_signup():
|
||||
return render_template('index.html', content="signup.html")
|
||||
|
||||
# Function responsible for handling signups to the site
|
||||
|
||||
|
||||
@blueprint.post('/signup')
|
||||
def signup():
|
||||
database = UserController()
|
||||
@ -60,7 +66,8 @@ def signup():
|
||||
if request.form.get('seller'):
|
||||
user = Seller(
|
||||
request.form['username'],
|
||||
sha512(request.form['password'].encode()).hexdigest(), # Hashed as soon as it is recieved on the backend
|
||||
# Hashed as soon as it is recieved on the backend
|
||||
sha512(request.form['password'].encode()).hexdigest(),
|
||||
request.form['firstname'],
|
||||
request.form['lastname'],
|
||||
request.form['email'],
|
||||
@ -69,7 +76,8 @@ def signup():
|
||||
else:
|
||||
user = Customer(
|
||||
request.form['username'],
|
||||
sha512(request.form['password'].encode()).hexdigest(), # Hashed as soon as it is recieved on the backend
|
||||
# Hashed as soon as it is recieved on the backend
|
||||
sha512(request.form['password'].encode()).hexdigest(),
|
||||
request.form['firstname'],
|
||||
request.form['lastname'],
|
||||
request.form['email'],
|
||||
@ -82,7 +90,7 @@ def signup():
|
||||
return redirect("/login", code=307)
|
||||
|
||||
|
||||
### SIGN OUT FUNCTIONALITY
|
||||
# SIGN OUT FUNCTIONALITY
|
||||
# Function responsible for handling logouts from the site
|
||||
@blueprint.route('/logout')
|
||||
def logout():
|
||||
|
@ -2,6 +2,7 @@ class Category:
|
||||
'''
|
||||
Constructor for a category object
|
||||
'''
|
||||
|
||||
def __init__(self):
|
||||
self.id = 0
|
||||
self.name = ""
|
@ -1,9 +1,11 @@
|
||||
from datetime import datetime
|
||||
|
||||
|
||||
class Order:
|
||||
'''
|
||||
Constructor for an order object
|
||||
'''
|
||||
|
||||
def __init__(self):
|
||||
self.id = 0
|
||||
self.sellerID = 0
|
||||
|
@ -1,13 +1,14 @@
|
||||
from product import Product
|
||||
|
||||
|
||||
class CarPart(Product):
|
||||
'''
|
||||
Constructor for a car part
|
||||
|
||||
Contains additional information that is only relevant for car parts
|
||||
'''
|
||||
|
||||
def __init__(self):
|
||||
super().__init__()
|
||||
self.make = ""
|
||||
self.compatibleVehicles = list()
|
||||
|
@ -1,9 +1,11 @@
|
||||
from datetime import datetime
|
||||
|
||||
|
||||
class Product:
|
||||
'''
|
||||
Base class for a product
|
||||
'''
|
||||
|
||||
def __init__(self):
|
||||
self.id = 0
|
||||
self.name = ""
|
||||
@ -20,6 +22,7 @@ class Product:
|
||||
|
||||
No additional properties are assigned to the customer
|
||||
'''
|
||||
|
||||
def __init__(self, name: str, image: str, description: str, cost: float, category: int,
|
||||
seller_id: int, posted_date: datetime, quantity_available: int):
|
||||
self.id = 0
|
||||
@ -31,4 +34,3 @@ class Product:
|
||||
self.sellerID = seller_id
|
||||
self.postedDate = posted_date
|
||||
self.quantityAvailable = quantity_available
|
||||
|
@ -1,11 +1,13 @@
|
||||
from .user import User
|
||||
|
||||
|
||||
class Admin(User):
|
||||
'''
|
||||
Class constructor to instatiate an admin object
|
||||
|
||||
No additional properties are assigned to the admin
|
||||
'''
|
||||
|
||||
def __init__(self, username: str, password: str, firstname: str,
|
||||
lastname: str, email: str, phone: str):
|
||||
super().__init__(
|
||||
|
@ -1,14 +1,15 @@
|
||||
from .user import User
|
||||
|
||||
|
||||
class Customer(User):
|
||||
'''
|
||||
Class constructor to instatiate a customer object
|
||||
|
||||
No additional properties are assigned to the customer
|
||||
'''
|
||||
|
||||
def __init__(self, username: str, password: str, firstname: str,
|
||||
lastname: str, email: str, phone: str):
|
||||
super().__init__(
|
||||
username, password, firstname, lastname, email, phone, "Customer"
|
||||
)
|
||||
|
||||
|
@ -1,11 +1,13 @@
|
||||
from .user import User
|
||||
|
||||
|
||||
class Seller(User):
|
||||
'''
|
||||
Class constructor to instatiate a customer object
|
||||
|
||||
No additional properties are assigned to the customer
|
||||
'''
|
||||
|
||||
def __init__(self, username: str, password: str, firstname: str,
|
||||
lastname: str, email: str, phone: str):
|
||||
super().__init__(
|
||||
|
@ -1,8 +1,10 @@
|
||||
from abc import ABC
|
||||
|
||||
|
||||
class User(ABC):
|
||||
""" Functional Class constructor to initialise all properties in the base object
|
||||
with a value """
|
||||
|
||||
def __init__(self, username: str, password: str, firstname: str,
|
||||
lastname: str, email: str, phone: str, role: str):
|
||||
self.id = 0
|
||||
@ -12,4 +14,4 @@ class User(ABC):
|
||||
self.lastName = lastname
|
||||
self.email = email
|
||||
self.phone = phone
|
||||
self.role= role
|
||||
self.role = role
|
||||
|
@ -14,14 +14,14 @@ def create_connection(path: str, filename: str):
|
||||
|
||||
print("Database file open")
|
||||
# Execute creation scripts
|
||||
sql = open("scripts/create_tables.sql", "r");
|
||||
sql = open("scripts/create_tables.sql", "r")
|
||||
conn.executescript(sql.read())
|
||||
|
||||
print("Table creation complete")
|
||||
|
||||
# Populate with test data if we are in Test Mode
|
||||
if os.environ.get("ENVIRON") == "test":
|
||||
sql = open("scripts/test_data.sql", "r");
|
||||
sql = open("scripts/test_data.sql", "r")
|
||||
conn.executescript(sql.read())
|
||||
|
||||
except sqlite3.Error as e:
|
||||
@ -31,12 +31,15 @@ def create_connection(path: str, filename: str):
|
||||
conn.close()
|
||||
|
||||
# Ensure a directory is created given a path to it
|
||||
|
||||
|
||||
def create_directory(dir: str):
|
||||
try:
|
||||
os.makedirs(dir)
|
||||
except FileExistsError:
|
||||
pass
|
||||
|
||||
|
||||
def remove_file(dir: str):
|
||||
try:
|
||||
os.remove(dir)
|
||||
@ -44,7 +47,6 @@ def remove_file(dir: str):
|
||||
pass
|
||||
|
||||
|
||||
|
||||
dir = r"./data/"
|
||||
db_name = r"wmgzon.db"
|
||||
|
||||
|
@ -1 +0,0 @@
|
||||
|
@ -1,8 +1,8 @@
|
||||
# Ensure test environment is set before using
|
||||
import scripts.create_database
|
||||
import os
|
||||
|
||||
# Setup test environment variables
|
||||
os.environ["ENVIRON"] = "test"
|
||||
|
||||
# Runs the database creation scripts
|
||||
import scripts.create_database
|
@ -16,11 +16,15 @@ product = Product(
|
||||
)
|
||||
|
||||
# Tests a new product can be created
|
||||
|
||||
|
||||
def test_create_product():
|
||||
db = ProductController()
|
||||
db.create(product)
|
||||
|
||||
# Tests the database maintains integrity when we try and add a product with the same details
|
||||
|
||||
|
||||
@pytest.mark.skip
|
||||
def test_duplicate_product():
|
||||
db = ProductController()
|
||||
@ -28,6 +32,8 @@ def test_duplicate_product():
|
||||
db.create(product)
|
||||
|
||||
# Tests that products can be refined by category
|
||||
|
||||
|
||||
def test_search_category():
|
||||
db = ProductController()
|
||||
|
||||
@ -48,6 +54,8 @@ def test_search_term():
|
||||
assert db.read_all(search_term="not_test") == None
|
||||
|
||||
# Test we the same product details get returned from the database
|
||||
|
||||
|
||||
def test_read_product():
|
||||
db = ProductController()
|
||||
|
||||
|
@ -23,17 +23,23 @@ seller = Seller(
|
||||
)
|
||||
|
||||
# Tests a new user can be created
|
||||
|
||||
|
||||
def test_create_user():
|
||||
db = UserController()
|
||||
db.create(customer)
|
||||
|
||||
# Tests the database maintains integrity when we try and add a user with the same details
|
||||
|
||||
|
||||
def test_duplicate_user():
|
||||
db = UserController()
|
||||
with pytest.raises(sqlite3.IntegrityError):
|
||||
db.create(customer)
|
||||
|
||||
# Test we the same user details get returned from the database
|
||||
|
||||
|
||||
def test_read_user():
|
||||
db = UserController()
|
||||
|
||||
@ -52,6 +58,8 @@ def test_create_seller():
|
||||
db.create(seller)
|
||||
|
||||
# Test that the same seller details get returned from the database
|
||||
|
||||
|
||||
def test_read_seller():
|
||||
db = UserController()
|
||||
|
||||
|
@ -1,6 +1,8 @@
|
||||
import pycodestyle
|
||||
|
||||
# Tests files to ensure they conform to pep8 standards
|
||||
|
||||
|
||||
def test_pep8_conformance():
|
||||
"""Test that we conform to PEP8."""
|
||||
pep8style = pycodestyle.StyleGuide()
|
||||
|
Loading…
Reference in New Issue
Block a user